Fix tls tests #1333
Fix tls tests #1333
Conversation
test/integration/acl-tls-test.js
Outdated
| @@ -50,22 +53,32 @@ var userCredentials = { | |||
| } | |||
| } | |||
|
|
|||
| describe('ACL with WebID+TLS', function () { | |||
| // TODO Remove skip. TLS is currently broken, but is not a priority to fix | |||
There was a problem hiding this comment.
maybe add:
... since the current Solid spec does not require supporting webid-tls on the resource server. The current spec only requires the resource server to support webid-oidc, and it requires the IDP to support webid-tls as a log in method, so that users of a webid-tls client certificate can still use their certificate (and not a username/password pair or other login method) to "bridge" from webid-tls to webid-oidc.
There was a problem hiding this comment.
or something to that extent. Would be even better if you link to a spec issue where this is stated, will post here if i find one.
There was a problem hiding this comment.
ah, found it: solid/solid-spec#171 (comment)
|
Impressive work, Jackson! Sorry you did all this work to restore the tests for webid-tls on the resource server, only to find out that it's broken and wont-fix, but it's definitely good to have these tests working, even if they are currently skipped. |
The tests for WebID TLS didn't actually test NSS. I have updated the tests properly which show that TLS is broken on NSS. Yet, because TLS will soon be depricated I will not fix.